refactor client-side handlers #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish-mudaraddi
force-pushed
the
refactor-client-handlers
branch
2 times, most recently
from
710fc3a to
511473e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 99.52% 99.63% +0.10%
==========================================
Files 114 105 -9
Lines 4193 3804 -389
==========================================
- Hits 4173 3790 -383
+ Misses 20 14 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
combine all client-side handlers into one. - We don't get any benefits from separate client-side handlers. - separate out client-side filter functions into standalone - found in client_side_filters.py - makes adding new filter functions easy - refactor client-side tests so its easier to add new ones
update docs to match change to client-side-handlers
anish-mudaraddi
force-pushed
the
refactor-client-handlers
branch
from
511473e to
30fd90e
Compare
anish-mudaraddi
force-pushed
the
refactor-client-handlers
branch
from
34bfc61 to
28dc9d3
Compare
gmatthews20
requested changes
Mar 11, 2025
Comment on lines
66
to
67
| # QueryPresets.CONTAINS: ["list_contains", "has"], | ||
| # QueryPresets.NOT_CONTAINS: ["list_not_contains", "has_not"] |
Collaborator
There was a problem hiding this comment.
Should these still be commented?
best to convert them into comma spaced strings for now
Collaborator
Author
|
decided LIST_CONTAINS and LIST_NOT_CONTAINS is not needed at the moment |
gmatthews20
previously approved these changes
Mar 18, 2025
Dmitry-Popovichev
approved these changes
Mar 18, 2025
gmatthews20
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge all client side handlers into one - simplifies the process to add new query presets