Skip to content

Conversation

@AlexCK-STFC
Copy link
Member

@AlexCK-STFC AlexCK-STFC commented Sep 29, 2025

Description:

First these need merging:
stfc/openstack-query-library#26 (includes minor bump)
stfc/openstack-query-library#25

Then I need to release 1.4.0

Then this will pass checks and can be merged

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

@AlexCK-STFC AlexCK-STFC force-pushed the AlexCK-STFC-patch-1 branch 2 times, most recently from 80bbfec to c98f4e1 Compare September 30, 2025 15:52
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c54c341) to head (2f269be).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #384   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2468      2470    +2     
  Branches       356       356           
=========================================
+ Hits          2468      2470    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexCK-STFC
Copy link
Member Author

Ready to merge, tested on dev, fixes issues.

@AlexCK-STFC AlexCK-STFC marked this pull request as ready for review October 1, 2025 09:01
@anish-mudaraddi anish-mudaraddi merged commit f7233d3 into main Oct 2, 2025
12 checks passed
@anish-mudaraddi anish-mudaraddi deleted the AlexCK-STFC-patch-1 branch October 2, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants