-
Notifications
You must be signed in to change notification settings - Fork 2
feat: 3.0 #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
balemoc
wants to merge
18
commits into
stonelasley:master
Choose a base branch
from
balemoc:hello-3.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 3.0 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: using tsconfig/recommended chore: update typescript
Owner
|
@balemoc you are a machine. thank you, sir! |
- added decodeOrThrow for gs-1-reader - tests for decodeOrThrow - some additional typescript fices in gs-1-reader
freshbyteadmin
approved these changes
Sep 9, 2025
freshbyteadmin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @balemoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stonelasley Hey long time no see, I just saw this wonderful project. I figured out that it needs some love.
This pull request modernizes the project's linting and testing infrastructure, replacing deprecated tools and updating configurations for improved maintainability and compatibility. It also introduces additional unit tests for barcode readers and refactors test code for clarity and consistency.
Tooling and Configuration Updates:
eslint.config.mjswith recommended configurations for both JavaScript and TypeScript, and updated the corresponding npm scripts inpackage.jsonto use ESLint. [1] [2]package.json.Test Suite Improvements:
decodeOrThrowmethod inCode39Reader,BaseGtinReader, andCode128Reader, ensuring correct handling of symbology, raw values, and embedded data. [1] [2] [3]Code Clean-up and Minor Fixes:
New features
Introduced ParsedBarcode to deprecate BarcodeValue
Modern, strongly-typed class for parsed barcode results.
Uses a strictly-typed [values] array (BarcodeValueEntry[]), where each entry has a (string or AICode) and a [value](string | number | Date | undefined).
Provides the method getApplicationIdentifier to retrieve a value by its application identifier code in a type-safe way.
Omits legacy fields and methods like [pluck] [errorMessage], and [success]) for a cleaner, more focused API.
Ensures immutability for its main properties via readonly.
Legacy implementation, now marked as deprecated (BarcodeValue)
Fixes #42 #43