Skip to content

Conversation

@alanshaw
Copy link
Member

@alanshaw alanshaw commented Oct 28, 2025

Aims to fix:

=== RUN   TestFXSpaceContentRetrieve/space/content/retrieve
    ucan_fx_test.go:106: 
            Error Trace:    /Users/runner/work/piri/piri/pkg/service/retrieval/ucan_fx_test.go:106
            Error:          Received unexpected error:
                            sending message: doing HTTP request: Get "http://localhost:49232/piece/bafkreibmtmy3p773cf7uj24hfg2dhniov45xv4p54cs4oe3nxhm7p3ov5e": dial tcp [::1]:49232: connect: connection refused

Possibly because the server is not ready to accept connections yet.

@alanshaw alanshaw requested a review from frrist as a code owner October 28, 2025 12:39

testApp.RequireStart()
defer testApp.RequireStop()
piritestutil.WaitForHealthy(t, &appConfig.Server.PublicURL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a couple more tests that would benefit from the addition of this, would be nice to add this call there, but non-blocking.

@alanshaw alanshaw merged commit 4a678dd into main Oct 30, 2025
8 checks passed
@alanshaw alanshaw deleted the ash/fix/wait-for-healthy-piri branch October 30, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants