Adds -profile:v and -pix_fmt flag options to encoding_options.rb #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks. I've been on vacation for a few days. Will check it out! |
bikeath1337
requested changes
Mar 21, 2017
Collaborator
bikeath1337
left a comment
bikeath1337
left a comment
There was a problem hiding this comment.
Let's use single quotes if we don't require interpolation.
Collaborator
|
@Mishaux I forgot to ask to include an update to the docs. Thanks! |
Contributor
Author
|
Sure, will do. Might take me a day or two! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds following options to encoding_options:
-pix_fmt ~ Allows specification of pixel format
-profile:v ~ Alternate syntax for specifying x264 base profile. I see there is an option for setting a -vprofile flag with convert_x264_vprofile, but that doesn't seem to work with my version of ffmpeg on osx (3.2.2). It seems to require the flag to be -profile:v
Also includes passing specs.