This repository was archived by the owner on Dec 22, 2020. It is now read-only.
Allow mongodb ssl connections by adding missing parameters for cert, … #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the project is, SSL connections were not fully supported. Most people who don't use ssl connections to mongodb servers think all you need is to set the ssl parameter in the connection string, but if you follow the best practices you need to provide your own SSL client certificates for connecting to the servers as well.
This PR adds three command line arguments which resolve this issue:
--mongo-sslcert- SSL public certificate--mongo-sslkey- SSL private key--mongo-sslca- SSL CA certificate to be used to verify the server certificateI have tested this code and it works to connect to our replicaset over SSL