-
-
Notifications
You must be signed in to change notification settings - Fork 34
chore(deps): bump serialize-error from 8.1.0 to 12.0.0 #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@dependabot rebase |
d4a088a to
31fe416
Compare
|
Should we wait for microsoft/vscode#130367? |
serialize-error has no top-level await, and for a short while now Node.js on versions 20 22, 23, and 24 has been supporting requiring ESM modules without needing to convert the whole project to ESM. Right now, the first version of VS Code to release with a version of Node.js that supports this, is 1.101, the May 2025 update. However, this extension currently supports VS Code as old as 1.83, which is from September 2023. May 2025 may be a bit too soon if we want to support a wide breadth of versions, but perhaps at some point when May 2025 isn't that soon anymore, we could just bump the supported version and this should work. The only thing that would block us is jestjs/jest#15716; I ran some tests and tried it and it turns out Jest hasn't been updated to take the require(esm) pattern into account yet. |
I wonder if we would need to support so many versions. 🤔 |
I don't think we do. In situations like this it holds us back (though in this specific case even if we were only supporting the latest VS Code we'd still run into that problem with Jest). But I think we probably should support at least several months of versions of VS Code. |
Sounds good. I'd suggest creating the support policy to prevent us from outdated dependencies issue:
|
|
@dependabot rebase |
Bumps [serialize-error](https://github.com/sindresorhus/serialize-error) from 8.1.0 to 12.0.0. - [Release notes](https://github.com/sindresorhus/serialize-error/releases) - [Commits](sindresorhus/serialize-error@v8.1.0...v12.0.0) --- updated-dependencies: - dependency-name: serialize-error dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
31fe416 to
ba1141d
Compare
Bumps serialize-error from 8.1.0 to 12.0.0.
Release notes
Sourced from serialize-error's releases.
... (truncated)
Commits
4d0f3b212.0.0b6ff2ebAdd support forAggregateError(#103)64ce883Fix return type forunknowninput (#105)e593d37Avoid breaking with bad custom constructors (#104)7fc2898Tighten Error determination (#101)1d8395bStop making non-Error properties non-enumerable (#102)98bbe4eRequire Node.js 18+ (#100)a031f98Revert "Remove JSON.stringify from usage" (#99)a2df3aeFix usage description (#97)29b0fcb11.0.3You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)