[JavaScript] Use more-specific scopes for in/of/is #4420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
previously approved these changes
Dec 25, 2025
jrappen
previously approved these changes
Dec 25, 2025
jrappen
changed the title
deathaxe
reviewed
Dec 25, 2025
deathaxe
reviewed
Dec 25, 2025
deathaxe
approved these changes
Dec 26, 2025
jrappen
approved these changes
Dec 26, 2025
deathaxe
added a commit
to deathaxe/sublime-packages
that referenced
this pull request
Dec 27, 2025
This commit scopes logical `in` keyword `keyword.operator.logical`, following the scheme of PR sublimehq#4227 and sublimehq#4271 as a follow-up of sublimehq#4420. It fixes a syntax test, using invalid syntax `for (var in list)`, in which `in` was scoped logical keyword due to `var` not being a valid iterator variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #4419 and updates all test cases. For consistency, I also changed the
isoperator in TypeScript to bekeyword.operator.word.is.js(I can back this out if needed). Allkeyword.operator.word.jsscopes should now be specific.Closes #4419