Sql query support #47
Open
+1,347
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalabukdima
reviewed
Dec 22, 2025
|
|
||
| pub enum QueryType { | ||
| PlainQuery, | ||
| SQLQuery, |
Collaborator
There was a problem hiding this comment.
Usually abbreviations in CamelCase are formatted as SqlQuery
Please also run cargo fmt over the code, there are many other issues
| prometheus-client = "0.23" | ||
| prost = "0.12.3" | ||
| polars-plan = "0.43.1" | ||
| polars = { version = "0.43.1", features = ["serde", "strings", "json", "polars-io", "polars-plan", "parquet", "dtype-full", "lazy", "temporal", "is_in"] } |
Collaborator
There was a problem hiding this comment.
Are you using all these features here? Usually, cargo is smart enough to unite the features from all the dependencies, so that you only need to specify the ones you use
| sqd-network-transport = { git = "https://github.com/subsquid/sqd-network.git", rev = "c7fbb0b", version = "3.0.0", features = ["worker", "metrics"] } | ||
| sqd-query = { git = "https://github.com/subsquid/data.git", rev = "4c089d8", features = ["parquet"] } | ||
| sqd-polars = { git = "https://github.com/subsquid/data.git", rev = "4c089d8" } | ||
| qplan = {git = "https://github.com/subsquid/qplan.git", rev = "354f265" } |
Collaborator
There was a problem hiding this comment.
Can it have a clearer name? query_plan for example
| @@ -0,0 +1,615 @@ | |||
| //! Convert a query plan to a polars target plan. | |||
Collaborator
There was a problem hiding this comment.
You're claiming ownership of Tobias' code here in terms of git history :)
Ideally, this can be handled with git subtree. If you don't want to deal with it, let's at least leave a link to the original
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.