Skip to content

Conversation

@melvinmilkiyas
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • Both solutions correctly implement binary search with appropriate adjustments for their respective problems.
    • The code is clean, with good variable naming and clear logic flow.
    • The comments provide a good high-level overview of the approach.
  • Areas for Improvement:
    • The problem descriptions in the comments could be more detailed to clarify the specific problem being solved (e.g., mentioning that "Search in Infinite sorted array" involves an unbounded array).
    • For "Search in Infinite sorted array," consider adding a check to handle cases where the target might be smaller than the first element, though this is not strictly necessary given the problem constraints.
    • The pass statement in "Search in Infinite sorted array" is unnecessary and can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants