Skip to content

Conversation

@mwolabs
Copy link
Contributor

@mwolabs mwolabs commented Jun 24, 2025

Hi, I'm Mwonji. Forgive me if I'm not following the guidelines. I'm just learning, came here through The Odin Project. Total noob. Don't even know the markup language of the document I've just edited. Don't yet know how to use Git or GitHub. First commit or pull request ever.
I noticed that the bash input and output instructions on lines 499 to 503 were in the same box, labeled "bash". It got me confused, thinking I was to enter the expected output as the second line of the bash command. Tried to edit the issue. Hope it works.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

I noticed that the bash input and output instructions on lines 499 to 503 were in the same box, labeled "bash". It got me confused, thinking I was to enter the expected output as the second line of the bash command. I'm just learning, came here through The Odin Project. Total noob. Don't even know the markup language of the document I've just edited. Don't yet know how to use Git or GitHub. First Commit ever.  Hope it works.
@github-actions
Copy link

github-actions bot commented Jun 24, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1495

The following changes were observed in the rendered markdown documents:

 03-create.md | 3 +++
 md5sum.txt   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-08-18 11:32:54 +0000

@omsai
Copy link
Contributor

omsai commented Jun 25, 2025

@mwolabs Thank you for the pull request!

@bkmgit White the commit looks good to me I wanted to run this by you before merging because I think we at least should have a more informative commit message; ordinarily I would suggest that @mwolabs should amend the commit message and then do a force push, but default the commit message and branch name suggests it was created using GitHub's graphical editor. Also note that I get a slight different error on macOS 15.5 bash 3.2.57 but the error is similar enough:

$ cd ~/Desktop
$ unzip ~/Downloads/shell-lesson-data.zip
[...]
$ mkdir thesis
$ mkdir -p ../project/data ../project/results
$ cd ~/Desktop/shell-lesson-data/exercise-data/writing
$ cd thesis/
$ nano draft.txt
$ cat draft.txt
It's not "publish or perish" anymore.
It's "share and thrive".
$ cd ..
$ mv thesis/draft.txt thesis/quotes.txt
$ mv thesis/quotes.txt .
$ cp quotes.txt thesis/quotations.txt
$ cp -r thesis/ thesis_backup
$ cp thesis thesis_backup
cp: thesis is a directory (not copied).

@omsai omsai changed the title Update 03-create.md separate cp command from error output Jul 25, 2025
@bkmgit
Copy link
Contributor

bkmgit commented Aug 18, 2025

@omsai On Fedora with Bash 5.2.37 get cp: -r not specified; omitting directory 'thesis'

Maybe it is helpful to have some warnings in the instructor notes that some of the messages may vary.

Feel free to amend the commit message.

Co-authored-by: Pariksheet Nanda <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 18, 2025
@omsai omsai merged commit 76096c2 into swcarpentry:main Aug 18, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 18, 2025
Auto-generated via `{sandpaper}`
Source  : 76096c2
Branch  : main
Author  : mwolabs <[email protected]>
Time    : 2025-08-18 11:42:02 +0000
Message : separate cp command from error output (#1495)

Separate cp command from error output

> I noticed that the bash input and output instructions on lines 499 to 503 were in the same box, labeled "bash". It got me confused, thinking I was to enter the expected output as the second line of the bash command.

Co-authored-by: Benson Muite <[email protected]>
Co-authored-by: Pariksheet Nanda <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 18, 2025
Auto-generated via `{sandpaper}`
Source  : 339edc1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-08-18 11:43:02 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 76096c2
Branch  : main
Author  : mwolabs <[email protected]>
Time    : 2025-08-18 11:42:02 +0000
Message : separate cp command from error output (#1495)

Separate cp command from error output

> I noticed that the bash input and output instructions on lines 499 to 503 were in the same box, labeled "bash". It got me confused, thinking I was to enter the expected output as the second line of the bash command.

Co-authored-by: Benson Muite <[email protected]>
Co-authored-by: Pariksheet Nanda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants