RedundantLoadElim: Fix invalid destructure_struct emission without aggressive reg2mem
#85524
+62
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci smoke test |
…aggressive reg2mem The `shouldExpand` in `OptUtils.swift` was incorrectly returning `true` unconditionally when `useAggressiveReg2MemForCodeSize` was disabled. The expansion might be invalid for types with addr-only types and structs with deinit, but we didn't check them before. This could lead to invalid `destructure_struct` instructions without `drop_deinit` being emitted.
kateinoigakukun
force-pushed
the
yt/fix-non-reg2mem-rle-crash
branch
from
722b92c to
fba5c9d
Compare
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please smoke test macOS platform |
Member
Author
|
swiftlang/swift-docc#1351 |
Member
Author
|
swiftlang/swift-docc#1352 |
kateinoigakukun
requested review from
eeckstein,
jckarter and
rjmccall
as code owners
Member
Author
|
Merging to unblock CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
shouldExpandinOptUtils.swiftwas incorrectly returningtrueunconditionally whenuseAggressiveReg2MemForCodeSizewas disabled. The expansion might be invalid for types with addr-only types and structs with deinit, but we didn't check them before. This could lead to invaliddestructure_structinstructions withoutdrop_deinitbeing emitted.Close #85521