Show Downtimes #244
Draft
Show Downtimes #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This can be merged standalone, however the next steps will build on this:
|
BuJo
force-pushed
the
external-silencer-v2
branch
3 times, most recently
from
ffc5109 to
055569a
Compare
* Unify the connector interface as `Collector` has never been used by itself. * alerts/silences/states are separate concepts, split those into their own files to prepare for adding to silences.
* As we now need the alerts to exist, do not filter silences/ service downtimes or similar inside the connector but filter them via the aggregator. * Fixes some other random breakagaes around showint the new known problems on web.
BuJo
force-pushed
the
external-silencer-v2
branch
from
055569a to
966071f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As preparation for using an external silencer, this PR adds current downtimes as a concept.