feat/add-service-authorization-class/SDKPY-129#47
Merged
felipefdl merged 4 commits intofeat/add-secrets-class/SDKPY-128from Jul 26, 2025
Merged
Conversation
…Create, tokenDelete, and tokenEdit
mateuscardosodeveloper
changed the title
mateuscardosodeveloper
requested review from
RicardoStoklosa,
Copilot and
felipefdl
mateuscardosodeveloper
added
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new feature for service authorization, adding endpoints for listing, creating, deleting, and editing service authorization tokens as well as updating the associated documentation and tests.
- Added corresponding methods and type definitions for service authorization in the SDK.
- Included tests to validate tokenList, tokenCreate, tokenDelete, and tokenEdit functionality.
- Updated documentation to reflect the new service authorization features.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Resources/test_service_authorization.py | New tests for service authorization endpoints. |
| src/tagoio_sdk/modules/Resources/Service_Authorization_Types.py | Added types for service authorization responses and queries. |
| src/tagoio_sdk/modules/Resources/Service_Authorization.py | Implemented service authorization endpoints (tokenList, tokenCreate, etc.). |
| src/tagoio_sdk/modules/Resources/Resources.py | Updated to include ServiceAuthorization initialization. |
| src/tagoio_sdk/modules/Resources/AccountDeprecated.py | Added ServiceAuthorization to deprecated account class. |
| docs/source/Resources/index.rst | Updated resource index documentation. |
| docs/source/Resources/ServiceAuthorization/index.rst | Added documentation page for service authorization endpoints. |
| docs/source/Resources/ServiceAuthorization/Service_Authorization_Types.rst | Added documentation for service authorization types. |
| os.environ["T_ANALYSIS_TOKEN"] = "your_token_value" | ||
|
|
||
|
|
||
| def mockTokenList() -> list[TokenDataList]: |
There was a problem hiding this comment.
The return type annotation of mockTokenList indicates a list[TokenDataList] but the function returns a dictionary. Consider updating the return type annotation to match the actual returned value.
Suggested change
| def mockTokenList() -> list[TokenDataList]: | |
| def mockTokenList() -> dict: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does PR do?
This pull request introduces a new ServiceAuthorization class to support authorization functionality. It includes the implementation of the ServiceAuthorization module, related types, comprehensive unit tests, and updated documentation.
test_service_authorization.pyto ensure reliabilityJIRA cards.
SDKPY-129
Type of alteration
Tests