Skip to content

Ensure refs are forwarded when freezing data #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Ensure refs are forwarded when freezing data #3390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce9ddb3
Ensure ref are forwarded when freezing data
thecrypticace Jul 17, 2024
408540f
update changelog
RobinMalfait Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@headlessui-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Allow home/end key default behavior inside `ComboboxInput` when `Combobox` is closed ([#3798](https://github.com/tailwindlabs/headlessui/pull/3798))
- Ensure interacting with a `Dialog` on iOS works after interacting with a disallowed area ([#3801](https://github.com/tailwindlabs/headlessui/pull/3801))
- Freeze Listbox values as soon as possible when closing ([#3802](https://github.com/tailwindlabs/headlessui/pull/3802))
- Ensure refs are forwarded when freezing data ([#3390](https://github.com/tailwindlabs/headlessui/pull/3390))

## [2.2.8] - 2025-09-12

Expand Down
14 changes: 12 additions & 2 deletions packages/@headlessui-react/src/internal/frozen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
import React, { useState } from 'react'
import React, { cloneElement, isValidElement, useState } from 'react'

export function Frozen({ children, freeze }: { children: React.ReactNode; freeze: boolean }) {
function FrozenFn(
{ children, freeze }: { children: React.ReactNode; freeze: boolean },
ref: React.ForwardedRef<HTMLElement>
) {
let contents = useFrozenData(freeze, children)

if (isValidElement(contents)) {
return cloneElement(contents as React.ReactElement, { ref })
}

return <>{contents}</>
}

export const Frozen = React.forwardRef(FrozenFn)

export function useFrozenData<T>(freeze: boolean, data: T) {
let [frozenValue, setFrozenValue] = useState(data)

Expand Down