Skip comments in Ruby files when checking for class names #19243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/issue-19239
branch
from
bc1c637 to
fa2be75
Compare
Unless it’s part of `!important` at the end
RobinMalfait
reviewed
Nov 3, 2025
Comment on lines
+81
to
+119
| b'"' => { | ||
| cursor.advance(); | ||
|
|
||
| while cursor.pos < len { | ||
| match cursor.curr { | ||
| // Escaped character, skip ahead to the next character | ||
| b'\\' => cursor.advance_twice(), | ||
|
|
||
| // End of the string | ||
| b'"' => break, | ||
|
|
||
| // Everything else is valid | ||
| _ => cursor.advance(), | ||
| }; | ||
| } | ||
|
|
||
| cursor.advance(); | ||
| continue; | ||
| } | ||
|
|
||
| b'\'' => { | ||
| cursor.advance(); | ||
|
|
||
| while cursor.pos < len { | ||
| match cursor.curr { | ||
| // Escaped character, skip ahead to the next character | ||
| b'\\' => cursor.advance_twice(), | ||
|
|
||
| // End of the string | ||
| b'\'' => break, | ||
|
|
||
| // Everything else is valid | ||
| _ => cursor.advance(), | ||
| }; | ||
| } | ||
|
|
||
| cursor.advance(); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Can we add some tests where we handle quotes? We have to be careful with these because it could be that you start a sentence with a ' in it and never close it.
%p a quote here can't exist, or can it
-#
This won't be displayed (there is a quote here as well)
Nor will this
Nor will this.
%p a quote here can't exist, or can it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19239