feat: three minor enhancement (#34110)

[yihaoDeng]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @yihaoDeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements minor enhancements primarily focused on refining the handling of user-specific resource limits, particularly for vnode_per_call. It updates system-wide default values, formally integrates the vnode_per_call field into the user system table schema, and activates the corresponding data retrieval and setting logic for user objects. These changes aim to streamline and standardize the management of user resource configurations.

Highlights

• Default User Limits: The default values for TSDB_USER_CALL_PER_SESSION_DEFAULT and TSDB_USER_VNODE_PER_CALL_DEFAULT have been updated from 128 to -1, indicating a change in how these user resource limits are managed, likely signifying 'unlimited' or 'system default'.
• Vnode Per Call Integration: The vnode_per_call field is now explicitly included in the userUsersFullSchema system table, making it an official part of the user configuration schema.
• User Object Data Retrieval: The logic responsible for retrieving and setting the vnodePerCall property for user objects has been activated, removing a previously commented-out block that indicated it was 'not supported yet'.
• Consistent Default Options: The createDefaultUserOptions function now correctly utilizes TSDB_USER_VNODE_PER_CALL_DEFAULT for vnodePerCall, ensuring consistency with the newly defined default value in tdef.h.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces three minor enhancements, primarily focused on enabling the vnode_per_call user option. The changes are consistent across the modified files.

My review has identified a critical compilation error due to a typo in source/dnode/mnode/impl/src/mndUser.c. Additionally, there's a confusing and outdated comment in source/libs/parser/src/parAstCreater.c that should be cleaned up.

Once these issues are addressed, the changes look good.

[gemini-code-assist]

There's a typo here. cons should be const. This will cause a compilation error.

    COL_DATA_SET_VAL_GOTO((const char *)&pUser->vnodePerCall, false, pUser, pShow->pIter, _exit);