fix: catalog tasks management

[kailixu]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @kailixu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and reliability of asynchronous catalog operations by implementing a more structured error handling approach within the ctgLaunchGetUserTask function. The changes prevent potential memory leaks by ensuring proper resource deallocation on error paths and centralize task finalization logic, leading to more predictable and stable system behavior.

Highlights

• Improved Error Handling: The error handling mechanism in ctgLaunchGetUserTask has been refactored to use CTG_ERR_JRET instead of CTG_ERR_RET, directing control to a centralized cleanup block.
• Memory Leak Fix: A potential memory leak was addressed by ensuring that rsp.pRawRes is properly freed using taosMemoryFreeClear when an error occurs during the ctgLaunchGetUserTask execution.
• Centralized Resource Cleanup: A new _return label and associated logic have been introduced to centralize the finalization of tasks and resource cleanup, ensuring consistent state management upon exiting the function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors error handling in ctgLaunchGetUserTask to use a single exit point for cleanup and fixes a memory leak. While one memory leak is correctly addressed, the refactoring unfortunately introduces a new memory leak on a different error path. I have provided a critical comment with a suggested fix for this new issue.

[Copilot]

Pull request overview

This PR addresses exception handling and memory leak issues in the ctgLaunchGetUserTask function within the catalog library's async operations.

Key Changes:

• Converts error handling from immediate return (CTG_ERR_RET) to goto-based cleanup (CTG_ERR_JRET) to ensure proper resource cleanup
• Adds explicit memory cleanup before error returns to prevent memory leaks
• Introduces a centralized error handling section (_return label) with task cleanup logic

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.