-
Notifications
You must be signed in to change notification settings - Fork 5k
chore(jdbc): update jdbc version #34157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sheyanjie-qq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance task: updating the version of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the taos-jdbcdriver version to 3.8.0 across multiple example projects and documentation files. The changes are straightforward version bumps. However, I've noticed that the version number is hardcoded in numerous pom.xml files. To improve maintainability and simplify future dependency updates, I recommend centralizing version management. A good approach would be to use Maven properties for versions, ideally managed in a parent POM for all JDBC examples. I've left specific comments on the pom.xml files with this suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the TDengine JDBC driver version from 3.7.8 to 3.8.0 across documentation and example projects. Version 3.8.0 includes improvements such as least connections load balancing algorithm, connection rebalancing after failure recovery, BearerToken authentication support, and various bug fixes.
Key Changes:
- Updated JDBC driver version from 3.7.8 to 3.8.0 in Chinese documentation
- Updated JDBC driver version in all example project POM files (9 projects)
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/zh/07-develop/01-connect/index.md | Updated JDBC driver version reference in Chinese connection documentation |
| docs/examples/java/pom.xml | Updated JDBC driver dependency version for Java examples |
| docs/examples/JDBC/taosdemo/pom.xml | Updated JDBC driver dependency version for taosdemo example |
| docs/examples/JDBC/springbootdemo/pom.xml | Updated JDBC driver dependency version for Spring Boot demo |
| docs/examples/JDBC/mybatisplus-demo/pom.xml | Updated JDBC driver dependency version for MyBatis Plus demo |
| docs/examples/JDBC/highvolume/pom.xml | Updated JDBC driver dependency version for high volume example |
| docs/examples/JDBC/consumer-demo/pom.xml | Updated JDBC driver dependency version for consumer demo |
| docs/examples/JDBC/connectionPools/pom.xml | Updated JDBC driver dependency version for connection pools example |
| docs/examples/JDBC/SpringJdbcTemplate/pom.xml | Updated JDBC driver dependency version for Spring JDBC Template example |
| docs/examples/JDBC/JDBCDemo/pom.xml | Updated JDBC driver dependency version for basic JDBC demo |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
690d811 to
600f443
Compare
600f443 to
39ec41c
Compare
|
Error caused by unstable cases. |
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.