Skip to content

fix: fix the race condition caused by setting client = nil during client closure #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zitsen merged 1 commit into from
Dec 22, 2025
Merged

fix: fix the race condition caused by setting client = nil during client closure #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions taosWS/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ type taosConn struct {
endpoint string
closed uint32
closeCh chan struct{}
closeOnce sync.Once
}

type message struct {
Expand Down Expand Up @@ -161,16 +162,13 @@ func (tc *taosConn) Begin() (driver.Tx, error) {
}

func (tc *taosConn) Close() (err error) {
if !tc.isClosed() {
tc.closeOnce.Do(func() {
atomic.StoreUint32(&tc.closed, 1)
close(tc.closeCh)
}
if tc.client != nil {
err = tc.client.Close()
}
tc.client = nil
tc.cfg = nil
tc.endpoint = ""
if tc.client != nil {
err = tc.client.Close()
}
})
return err
}

Expand Down