Skip to content

Conversation

@Legend-Master
Copy link
Contributor

Description

@Legend-Master Legend-Master requested a review from a team as a code owner April 15, 2025 01:44
@github-project-automation github-project-automation bot moved this to 🪵 Backlog in Documentation Apr 15, 2025
@netlify
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for tauri-v1 ready!

Name Link
🔨 Latest commit b443f06
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v1/deploys/67fdd63a662b7f000854bb2c
😎 Deploy Preview https://deploy-preview-3258--tauri-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Legend-Master Legend-Master marked this pull request as draft April 15, 2025 01:58
@Legend-Master
Copy link
Contributor Author

Well, this banner doesn't seem to work, as it still shows the latest to be v1

image

Guess we change the announcement instead

@Legend-Master Legend-Master marked this pull request as ready for review April 15, 2025 02:29
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@vasfvitor
Copy link
Contributor

maybe we could go a step further and update the title from "Tauri Apps" to "Tauri v1"

@Legend-Master Legend-Master changed the title Mark v1 docs as not actively maintained Add on old version notice Apr 15, 2025
@Legend-Master
Copy link
Contributor Author

maybe we could go a step further and update the title from "Tauri Apps" to "Tauri v1"

Changed

Also I don't have permission to merge to v1 branch, so maybe you could merge it instead 🙃

@vasfvitor vasfvitor merged commit fe605f3 into v1 Apr 15, 2025
7 checks passed
@vasfvitor vasfvitor deleted the mark-v1-not-actively-maintained branch April 15, 2025 06:22
@github-project-automation github-project-automation bot moved this from 🪵 Backlog to ✅ Done in Documentation Apr 15, 2025
@RazielMartelus96
Copy link

RazielMartelus96 commented Apr 15, 2025

As a humble suggestion, whilst the PR has already been merged and closed, I felt it sensible to mention the light blue color does compliment Tauri's UI... a Deprecation warning is not designed to "fit in" in my humble opinion.

It's purpose is to make it abundantly clear it is the V1 version, and hence should not blend in with the UI color pallet. Rather, it should do the opposite and be direct and contrasting (For example, a shade of red).

I hope this is not seen as pedantic, and indeed does have a precedent, such as with old versions of unity documentation: https://docs.unity3d.com/2017.4/Documentation/Manual/index.html

Not too invested in dying on this hill, but thought it was at least worth mentioning as, on investigation of your link, I didn't initially notice the warning.

That said thank you for the contribution and it is very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants