-
Notifications
You must be signed in to change notification settings - Fork 836
Add on old version notice #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tauri-v1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vasfvitor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
maybe we could go a step further and update the title from "Tauri Apps" to "Tauri v1" |
Changed Also I don't have permission to merge to v1 branch, so maybe you could merge it instead 🙃 |
|
As a humble suggestion, whilst the PR has already been merged and closed, I felt it sensible to mention the light blue color does compliment Tauri's UI... a Deprecation warning is not designed to "fit in" in my humble opinion. It's purpose is to make it abundantly clear it is the V1 version, and hence should not blend in with the UI color pallet. Rather, it should do the opposite and be direct and contrasting (For example, a shade of red). I hope this is not seen as pedantic, and indeed does have a precedent, such as with old versions of unity documentation: https://docs.unity3d.com/2017.4/Documentation/Manual/index.html Not too invested in dying on this hill, but thought it was at least worth mentioning as, on investigation of your link, I didn't initially notice the warning. That said thank you for the contribution and it is very much appreciated! |


Description