Skip to content

TWEAK: refactor allowed error in worker.start #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oshankkumar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TWEAK: refactor allowed error in worker.start #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,18 +240,24 @@ func (w *Worker) start(ctx context.Context, h handler) {
return
default:
err := w.RunOnce(ctx, h.QueueID, h.HandleFunc, opt)
if err != nil {
var wrappedError *wrappedHandlerError
if errors.As(err, &wrappedError) {
} else if errors.Is(err, ErrEmptyQueue) {
} else {
errFunc(err)
}
if err != nil && !allowedError(err) {
errFunc(err)
}
}
}
}

func allowedError(err error) bool {
var wrappedError *wrappedHandlerError
if errors.As(err, &wrappedError) {
return true
}
if errors.Is(err, ErrEmptyQueue) {
return true
}
return false
}

// ExportMetrics dumps queue stats if the queue implements MetricsExporter.
func (w *Worker) ExportMetrics() (*Metrics, error) {
var queueMetrics []*QueueMetrics
Expand Down