Skip to content

reorder SunsetTypes and make Civil dawn default #1199 #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

reorder SunsetTypes and make Civil dawn default #1199 #2714

wants to merge 3 commits into from

Conversation

@stefan123t
Copy link
Contributor

@stefan123t stefan123t commented Jun 9, 2025 •
edited
Loading

This PR fixes some criticism about #1199 namely the ordering of the Sunset types:

  • Standard dawn (90.8°)
  • Civil dawn (96° common)
  • Nautical dawn (102°)
  • Astronomical dawn (108°)

and making Civil dawn the common default

civil_dawn_common_default

@stefan123t
Copy link
Contributor Author

stefan123t commented Jun 9, 2025 •
edited
Loading

I do not know for sure whether the migrate() steps in ConfigurationClass are really necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stefan123t