Editorial: Allow formatting with default options when passing 'era' to formatter #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'era' is used as a standalone option, it should still trigger default formatting for PlainTime and PlainMonthDay. See tc39#3049 for more details.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3175 +/- ##
==========================================
- Coverage 96.96% 96.96% -0.01%
==========================================
Files 22 22
Lines 10219 10214 -5
Branches 1841 1838 -3
==========================================
- Hits 9909 9904 -5
Misses 261 261
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Draft test262 PR: tc39/test262#4634 |
ptomato
reviewed
Nov 6, 2025
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Probably needs a further change in lib/intl.mjs (see comment about PlainTime in the test262 PR)
Contributor
Author
ptomato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'era' is used as a standalone option, it should still trigger default formatting for PlainTime and PlainMonthDay.
See #3049 for more details.