Editorial: Remove early return in BubbleRelativeDuration #3179
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BubbleRelativeDuration` can be called `largestUnit` being a smaller unit than `smallestUnit`, but the algorithm only returns early when both units are equal to each other. Removing the early return and changing the loop condition and loop counter simplifies this operation a bit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 22 22
Lines 10219 10219
Branches 1841 1841
=======================================
Hits 9909 9909
Misses 261 261
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
reviewed
Nov 7, 2025
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
This doesn't seem like much of an improvement? The Repeat clause is currently written in such a way that it's obvious and easy to implement with a for loop, but this refactor makes it harder since the increment no longer happens at the end of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BubbleRelativeDurationcan be calledlargestUnitbeing a smaller unit thansmallestUnit, but the algorithm only returns early when both units are equal to each other. Removing the early return and changing the loop condition and loop counter simplifies this operation a bit.