Temporal: Split up old Chinese and Dangi calendar tests; remove out-of-normal-range dates #4667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
force-pushed
the
issue-4614
branch
3 times, most recently
from
10f5b2f to
9e53d64
Compare
ptomato
reviewed
Nov 14, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I didn't get all the way through it but here are some comments to go on.
ptomato
reviewed
Nov 15, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I think I'd recommend one of two things for this PR:
- Either leave all the tests in their original files and just delete the tests that invoke ill-defined years, and split them up in one or more follow-up PRs;
- Or we should expand the split-up tests in this PR to get better coverage (e.g., testing more than one year in
inLeapYearandmonthsInYear, etc.)
staging/sm/Temporal/PlainMonthDay/from-chinese-leap-month-common.js seems to invoke invalid Chinese years too.
test/intl402/Temporal/PlainDate/prototype/inLeapYear/chinese-calendar-dates.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/inLeapYear/dangi-calendar-dates.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainYearMonth/from/reference-day-chinese.js
Outdated
Show resolved
Hide resolved
Contributor
Author
Done in da4c282 |
catamorphism
force-pushed
the
issue-4614
branch
from
e37508a to
6f97426
Compare
Contributor
Author
I've tried to expand some of the tests to get better coverage. The PR is getting pretty big, so I'd rather do any further improvements in coverage in a future PR. |
…f-normal-range dates
… subtract/basic-chinese (and same for dangi-calendar)
…e, and PlainYearMonth
catamorphism
force-pushed
the
issue-4614
branch
from
e01527e to
b63db5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4614