Adds apikey example #738
Merged
Adds apikey example #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Steve Womack seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| static final String TASK_QUEUE = "MyTaskQueue"; | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| // For temporal cloud this would likely be ${namespace}.tmprl.cloud:7233 |
Contributor
There was a problem hiding this comment.
For API keys this is not true, the endpoint is like {region}.api.temporal.io:7233
Contributor
Author
There was a problem hiding this comment.
Fixed in the worker and the starter
Contributor
|
This ample should be linked in the main readme |
Contributor
|
Note the CLA does still need to be signed |
Contributor
Author
|
Huh, I thought I had completed that. I just did it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added an example for API Key & Temporal Cloud
Why?
We didn't have one previously
How was this tested:
Via the instructions in the README. It's the same as the ssl example (mTls with certs), and thus doesn't have unit tests
Any docs updates needed?
No