chore: cleanup Vec.lookup #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Changed pages
|
plt-amy
approved these changes
Sep 17, 2025
Having both Vec.lookup and Vec.lookup-safe is a bit silly, and we can get the best of both worlds by modifying Vec.lookup to only ever compute on the index. Suggested-by: Calvin Lee <[email protected]>
plt-amy
force-pushed
the
vec-lookup-fix
branch
from
7ea5b4c to
667f863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @4e554c4c, having both Vec.lookup and Vec.lookup-safe is a bit silly. We can get the best of both worlds by modifying Vec.lookup to only ever compute on the index.