lifecycle: Add Done() check to prevent Start() hanging on Serve failures #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Serve() fails while Start() is waiting for readiness probes, Start() should return immediately instead of hanging.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a concurrency issue where Start() could hang indefinitely when waiting for readiness probes if the background Serve() goroutine fails. The fix adds a check for the lifecycle's Done() channel in the probe waiting loop, allowing Start() to return immediately with the failure error instead of blocking.
Key changes:
- Added
lc.Done()case to the select statement in the readiness probe waiting loop - Added comprehensive test coverage for the hanging scenario with multiple actor types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lifecycle/lifecycle.go | Added Done() check in the readiness probe loop to detect Serve() failures and return immediately |
| lifecycle/lifecycle_test.go | Added test case validating that Start() doesn't hang when Serve() fails during probe wait |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Serve() fails while Start() is waiting for readiness probes, Start() should return immediately instead of hanging.
Provide context or links (Jira ticket, Slack thread) for both the reviewer and your future self: