Skip to content

ASoC: SOF: debug-dsp-ops: Update DSP PM testing flow #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranj063 merged 1 commit into from
Dec 17, 2024
Merged

ASoC: SOF: debug-dsp-ops: Update DSP PM testing flow #5251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 36 additions & 12 deletions sound/soc/sof/debug-dsp-ops.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,31 @@

#define MAX_FW_STATE_STRING_LEN 128

#define SOF_DSP_PM_D0I0 0
#define SOF_DSP_PM_D0I3 1

/*
* set dsp power state op by writing the requested power state.
* ex: echo D3 > dsp_power_state
*/
static int sof_dsp_ops_set_power_state(struct snd_sof_dev *sdev, char *state)
{
/* only D3 supported for now */
if (strcmp(state, "D3")) {
dev_err(sdev->dev, "Unsupported state %s\n", state);
const struct sof_ipc_pm_ops *pm_ops = sof_ipc_get_ops(sdev, pm);
struct sof_dsp_power_state target_state;
int ret;

/* Only D3/D0IO/D0I3 states supported */
if (strcmp(state, "D3") && strcmp(state, "D0I3") && strcmp(state, "D0I0")) {
dev_err(sdev->dev, "Unsupported DSP PM state %s\n", state);
return -EINVAL;
}

/* power off the DSP */
if (sdev->dsp_power_state.state == SOF_DSP_PM_D0) {
const struct sof_ipc_pm_ops *pm_ops = sof_ipc_get_ops(sdev, pm);
struct sof_dsp_power_state target_state = {
.state = SOF_DSP_PM_D3,
};
int ret;
/* put the DSP in D3 state */
if (!strcmp(state, "D3")) {
if (sdev->dsp_power_state.state == SOF_DSP_PM_D3)
return 0;

target_state.state = SOF_DSP_PM_D3;

/* notify DSP of upcoming power down */
if (pm_ops && pm_ops->ctx_save) {
Expand All @@ -43,9 +49,18 @@ static int sof_dsp_ops_set_power_state(struct snd_sof_dev *sdev, char *state)

sdev->enabled_cores_mask = 0;
sof_set_fw_state(sdev, SOF_FW_BOOT_NOT_STARTED);

return 0;
}

return 0;
/* handle D0I0/D0I3 transitions */
target_state.state = SOF_DSP_PM_D0;
if (!strcmp(state, "D0I3"))
target_state.substate = SOF_DSP_PM_D0I3;
else
target_state.substate = SOF_DSP_PM_D0I0;

return snd_sof_dsp_set_power_state(sdev, &target_state);
}

static int sof_dsp_ops_trace_init(struct snd_sof_dev *sdev, bool init)
Expand Down Expand Up @@ -175,7 +190,16 @@ static ssize_t sof_dsp_ops_tester_dfs_read(struct file *file, char __user *buffe
} else if (!strcmp(dentry->d_name.name, "dsp_power_state")) {
switch (sdev->dsp_power_state.state) {
case SOF_DSP_PM_D0:
string = "D0\n";
switch (sdev->dsp_power_state.substate) {
case SOF_DSP_PM_D0I0:
string = "D0I0\n";
break;
case SOF_DSP_PM_D0I3:
string = "D0I3\n";
break;
default:
break;
}
break;
case SOF_DSP_PM_D3:
string = "D3\n";
Expand Down
Loading