Skip to content

Conversation

@ujfalusi
Copy link
Collaborator

@ujfalusi ujfalusi commented Dec 4, 2024

ASoC: SOF: Intel: hda: Add module parameter to disable display audio bind

The SOF audio stack expects working Intel eGPU to probe and to have working
analog audio.
Under special circumstances users or developers can encounter issues of
no i915/Xe driver available and thus the SOF audio card is not probing:
- Booting kernel on a new architecture where the display driver is not yet
  working (cannot even force probed)
- running in virtualized environment without access to eGPU resources
- booting with nomodeset

While the percentage of affected users are small, it can still cause
unreasonable obstacles on their use cases.

With the disable_display_audio_bind=true module parameter the binding can
be disabled to let the SOF stack to probe and provide at least working
analog audio. Obviously the display audio will not work, but that is
expected.

and drop the PTL related patch.

The display audio binding can be disabled with a generic module
parameter, there is no longer a need for the patch:

options snd-sof-intel-hda-generic disable_display_audio_bind=true

bardliao
bardliao previously approved these changes Dec 4, 2024
lgirdwood
lgirdwood previously approved these changes Dec 4, 2024
@ranj063
Copy link
Collaborator

ranj063 commented Dec 4, 2024

@ujfalusi is the kernel build failure a CI issue?

@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Dec 5, 2024

Hrm:

/srv/home/jenkins/workspace/linux_config_build/linux/sound/soc/sof/intel/hda.c: In function ‘hda_dsp_probe_early’:
/srv/home/jenkins/workspace/linux_config_build/linux/sound/soc/sof/intel/hda.c:713:13: error: ‘disable_display_audio_bind’ undeclared (first use in this function)
  713 |         if (disable_display_audio_bind)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
/srv/home/jenkins/workspace/linux_config_build/linux/sound/soc/sof/intel/hda.c:713:13: note: each undeclared identifier is reported only once for each function it appears in
make[10]: *** [/srv/home/jenkins/workspace/linux_config_build/linux/scripts/Makefile.build:229: sound/soc/sof/intel/hda.o] Error 1
make[9]: *** [/srv/home/jenkins/workspace/linux_config_build/linux/scripts/Makefile.build:478: sound/soc/sof/intel] Error 2
make[8]: *** [/srv/home/jenkins/workspace/linux_config_build/linux/scripts/Makefile.build:478: sound/soc/sof] Error 2
  CC [M]  drivers/gpu/drm/i915/display/intel_connector.o
make[7]: *** [/srv/home/jenkins/workspace/linux_config_build/linux/scripts/Makefile.build:478: sound/soc] Error 2
make[6]: *** [/srv/home/jenkins/workspace/linux_config_build/linux/scripts/Makefile.build:478: sound] Error 2
make[6]: *** Waiting for unfinished jobs....

@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Dec 5, 2024

Aarrh, I see, pushing an update and thanks @ranj063 for spotting it!

…bind

The SOF audio stack expects working Intel eGPU to probe and to have working
analog audio.
Under special circumstances users or developers can encounter issues of
no i915/Xe driver available and thus the SOF audio card is not probing:
- Booting kernel on a new architecture where the display driver is not yet
  working (cannot even force probed)
- running in virtualized environment without access to eGPU resources
- booting with nomodeset

While the percentage of affected users are small, it can still cause
unreasonable obstacles on their use cases.

With the disable_display_audio_bind=true module parameter the binding can
be disabled to let the SOF stack to probe and provide at least working
analog audio. Obviously the display audio will not work, but that is
expected.

Signed-off-by: Peter Ujfalusi <[email protected]>
… GPU bind for PTL"

This reverts commit 29821cd.

The display audio binding can be disabled with a generic module
parameter, there is no longer a need for the patch:

options snd-sof-intel-hda-generic disable_display_audio_bind=true

Signed-off-by: Peter Ujfalusi <[email protected]>
@ujfalusi ujfalusi dismissed stale reviews from lgirdwood and bardliao via 2219976 December 5, 2024 07:01
@ujfalusi ujfalusi force-pushed the peter/sof/pr/intel-disable-display-audio-bind-01 branch from 47bf6f1 to 2219976 Compare December 5, 2024 07:01
@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Dec 5, 2024

Changes since v1:

  • Moved the disable_display_audio_bind module param declaration outside of the #if IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE), thanks again @ranj063 for noticing it!

@ranj063 ranj063 merged commit ce295d8 into thesofproject:topic/sof-dev Dec 5, 2024
10 of 14 checks passed
@ujfalusi ujfalusi deleted the peter/sof/pr/intel-disable-display-audio-bind-01 branch December 13, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants