forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 140
ASoC: SOF: Intel: hda: Add module parameter to disable display audio bind #5263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ranj063
merged 2 commits into
thesofproject:topic/sof-dev
from
ujfalusi:peter/sof/pr/intel-disable-display-audio-bind-01
Dec 5, 2024
Merged
ASoC: SOF: Intel: hda: Add module parameter to disable display audio bind #5263
ranj063
merged 2 commits into
thesofproject:topic/sof-dev
from
ujfalusi:peter/sof/pr/intel-disable-display-audio-bind-01
Dec 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
previously approved these changes
Dec 4, 2024
lgirdwood
previously approved these changes
Dec 4, 2024
Collaborator
|
@ujfalusi is the kernel build failure a CI issue? |
Collaborator
Author
|
Hrm: |
Collaborator
Author
|
Aarrh, I see, pushing an update and thanks @ranj063 for spotting it! |
…bind The SOF audio stack expects working Intel eGPU to probe and to have working analog audio. Under special circumstances users or developers can encounter issues of no i915/Xe driver available and thus the SOF audio card is not probing: - Booting kernel on a new architecture where the display driver is not yet working (cannot even force probed) - running in virtualized environment without access to eGPU resources - booting with nomodeset While the percentage of affected users are small, it can still cause unreasonable obstacles on their use cases. With the disable_display_audio_bind=true module parameter the binding can be disabled to let the SOF stack to probe and provide at least working analog audio. Obviously the display audio will not work, but that is expected. Signed-off-by: Peter Ujfalusi <[email protected]>
… GPU bind for PTL" This reverts commit 29821cd. The display audio binding can be disabled with a generic module parameter, there is no longer a need for the patch: options snd-sof-intel-hda-generic disable_display_audio_bind=true Signed-off-by: Peter Ujfalusi <[email protected]>
47bf6f1 to
2219976
Compare
Collaborator
Author
|
Changes since v1:
|
bardliao
approved these changes
Dec 5, 2024
lgirdwood
approved these changes
Dec 5, 2024
ranj063
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and drop the PTL related patch.