Skip to content

Update log to structured log and remove unnecessary information from it #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hamishpk merged 2 commits into from
Oct 1, 2025
Merged

Update log to structured log and remove unnecessary information from it #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b8d3b
Remove the whole digest from the error and only leave the hash in a s…
chryssakr Oct 1, 2025
29b270e
Update version and changelog
chryssakr Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 11.16.0
---------------
* Remove the whole digest of some elan logs and only add the hash using structured logs

Version 11.15.0
---------------
* Use logrus library for structured logs when they contain hashes (#330)
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
11.15.0
11.16.0
4 changes: 3 additions & 1 deletion elan/rpc/rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,9 @@ func (s *server) BatchUpdateBlobs(ctx context.Context, req *pb.BatchUpdateBlobsR
"hash": r.Digest.Hash,
}).Debug("Blob already exists remotely")
} else if err := s.writeAll(ctx, r.Digest, r.Data, compressed); err != nil {
log.Errorf("Error writing blob %s: %s", r.Digest, err)
logr.WithFields(logrus.Fields{
"hash": r.Digest.Hash,
}).WithError(err).Error("Error writing blob")
rr.Status.Code = int32(status.Code(err))
rr.Status.Message = err.Error()
blobsReceived.WithLabelValues(batchLabel(true, false), compressorLabel(compressed)).Inc()
Expand Down
Loading