fix href for the token url button

[shikharbsar]

No description provided.

[mnk-blr]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

[gemini-code-assist]

Summary of Changes

Hello @shikharbsar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the robustness and usability of the token URL button within the OAuth callback process. It ensures that the URL used for fetching tokens is correctly constructed and that the associated UI element provides a reliable link for users.

Highlights

• Improved URL Handling: I've added validation and normalization for window.INSTANCE_URL within static/oauth-callback.js. This ensures that the base URL used for constructing the token fetch URL is available and correctly formatted (i.e., ends with a trailing slash), preventing potential issues with malformed URLs.
• Enhanced Link Functionality: The href attribute of the 'manual-token-url-link' element in static/oauth-callback.js is now explicitly set to the generated token URL. This provides a direct and reliable target for the link, acting as a fallback or allowing users to directly open the link in a new tab.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes the href for the token URL button. The changes include a more robust construction of the tokenUrl by ensuring the base INSTANCE_URL has a trailing slash before appending the relative path, and setting the href attribute on the manual token link as a fallback. A potential issue with the URL construction logic was identified that could lead to runtime errors if the INSTANCE_URL contains query parameters, and a more robust implementation using the URL object's properties has been suggested to address this.

[ashubham]

remove the onclick