fix dropping 0x0 #61
Open
fix dropping 0x0 #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 7, 2025 14:14
Author
|
Btw. I think there is a lot of dead code? The Url class is never used, nor the classmethods |
Comment on lines
+27
to
+29
| has_width = bool(width) | ||
| height = options.get("height", None) | ||
| has_height = bool(height) |
Member
There was a problem hiding this comment.
Hey @Speedy1991, would it be better to use has_width = width is not None instead of has_width = bool(width)? It might handle cases like 0 more clearly.
And will be not necessary to include or 0
Author
|
I'll check this PR again in 1-2 weeks after my vacation. I'm still not sure if there is more refactor needed, depending the dead code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #60
I also added the .idea to gitignore