Skip to content

Conversation

@deralbert
Copy link
Contributor

Description:

This PR fixes a schema inconsistency in web-experiments in calendar-items.json where the code expects CalendarItemFormat (singular), but the schema defines it as CalendarItemFormats (plural).

Issue

  • The mismatch causes errors when the code attempts to reference CalendarItemFormat, leading to failures. For example, if one uses the following valid update call:
browser.calendar.items.update(eventItem.calendarId, eventItem.id, {
    format: "jcal",
    item: comp.toJSON()
});

despite all parameters being correct, this results in a DOMException / InvalidStateError.

  • The correct name in the schema is CalendarItemFormats (plural), which aligns with the definition of the enum CalendarItemFormats.

Fix

Updated references in calendar-items.json to use CalendarItemFormats consistently.

@deralbert deralbert requested a review from kewisch as a code owner March 8, 2025 23:33
rsjtdrjgfuzkfg pushed a commit to rsjtdrjgfuzkfg/thunderbird-birthdaycalendar that referenced this pull request Mar 16, 2025
This commit updates the calendar API experiment to
e730a7b2a483f5cf8f0e0d9dbc7bc6f9394501f5
with an additional fix from
thunderbird/webext-experiments#57

As a consequence, unsupported builds now work correctly on Thunderbird 136.
@kewisch kewisch merged commit 48b391c into thunderbird:main Apr 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants