Skip to content

Conversation

@barracuda156
Copy link
Contributor

@tibirna This builds with Qt4. Does it look sensible or can we improve something here?

@barracuda156 barracuda156 changed the title Unbreak build of 2.12 with Qt4 Unbreak build of 2.13 with Qt4 Oct 17, 2025
unsigned int fmw = fm.horizontalAdvance(txt);
#else
unsigned int fmw = fm.width(txt)
unsigned int fmw = fm.width(txt);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tibirna This is new in 2.13.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I screwed it when fixing branch tag size, never caught it because of lack of Qt < 5.11 to compile/test with. Sorry. Thanks for catching it.

@barracuda156 barracuda156 marked this pull request as ready for review October 17, 2025 00:08
@barracuda156
Copy link
Contributor Author

@tibirna When you get time, could you please take a look?

@tibirna
Copy link
Owner

tibirna commented Oct 17, 2025

Thanks a lot for the reprise. I looked over the code and left comments where requested. Things appear ok to me. Code compiles with Qt6 (apart from a new warning introduced by the latest, Qt 6.10, but it's not related to your changes) and the result seems to run properly.

Let me know when all is OK on your side and I will merge the pull request.

Thanks!

@barracuda156
Copy link
Contributor Author

barracuda156 commented Oct 17, 2025

@tibirna Builds with Qt4 and apparently runs on x86, I will verify on powerpc now.

Upd. I think it works fine:
qgit

@barracuda156
Copy link
Contributor Author

@tibirna Should be good to merge, provided you are satisfied with the current version of the patch.

@tibirna tibirna merged commit e2d44aa into tibirna:master Oct 26, 2025
2 checks passed
@tibirna
Copy link
Owner

tibirna commented Oct 26, 2025

@barracuda156 Thank you very much for your work, understanding and patience.

@barracuda156
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants