-
Notifications
You must be signed in to change notification settings - Fork 70
Unbreak build of 2.13 with Qt4 #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| unsigned int fmw = fm.horizontalAdvance(txt); | ||
| #else | ||
| unsigned int fmw = fm.width(txt) | ||
| unsigned int fmw = fm.width(txt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tibirna This is new in 2.13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I screwed it when fixing branch tag size, never caught it because of lack of Qt < 5.11 to compile/test with. Sorry. Thanks for catching it.
|
@tibirna When you get time, could you please take a look? |
|
Thanks a lot for the reprise. I looked over the code and left comments where requested. Things appear ok to me. Code compiles with Qt6 (apart from a new warning introduced by the latest, Qt 6.10, but it's not related to your changes) and the result seems to run properly. Let me know when all is OK on your side and I will merge the pull request. Thanks! |
|
@tibirna Builds with Qt4 and apparently runs on x86, I will verify on powerpc now. |
|
@tibirna Should be good to merge, provided you are satisfied with the current version of the patch. |
|
@barracuda156 Thank you very much for your work, understanding and patience. |
|
Thank you! |

@tibirna This builds with Qt4. Does it look sensible or can we improve something here?