Skip to content

metrics: clean up metrics when a store is removed from the cluster (#1751) #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: tidb-8.5
Choose a base branch
from
Open

metrics: clean up metrics when a store is removed from the cluster (#1751) #1761

wants to merge 1 commit into from
+611 −56

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1751

fix pingcap/tidb#63245

2025-09-05_004335 2025-09-05_004324

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-tidb-8.5 labels Sep 24, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2025
Merged
@ti-chi-bot
Copy link
Member Author

@cfzjywxk This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lysu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2025
@zyguan
Copy link
Contributor

zyguan commented Sep 24, 2025

There are too many conflicts due to #1700 , use #1762 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cfzjywxk cfzjywxk

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-tidb-8.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @zyguan @cfzjywxk