Conversation
|
What is your aim here? This PR is too broad as written, is there a specific property or feature you want to add? Having an example OSM feature to focus the discussion would be useful, please. |
|
We have added this to filter man_made=dyke in roads. I was thinking about adding is as is added pier and quay: https://github.com/tilezen/vector-datasource/blob/master/yaml/roads.yaml#L838 but it can have multiple highway tag values not only path. So I am not sure how to add it properly. |
|
Also here is one example: https://www.openstreetmap.org/way/516136046#map=16/48.2193/16.9755. |
|
If it's a dyke you're after then put this into the landuse layer instead, and just for the value(s) you're interested in. (We've moved away from adding in any random values from an OSM key and allowlisting them, too.) |
|
Should this be closed out in favor of #1929? |
|
@nvkelso we have added this because of our style similar to OpenTopoMap which also have this for roads. What should I do or change in order for this to be allowed to merge? |
Add man_made tag to roads layer