Backport to 2.24.x: #8988: Don't ignore additional filters on same column when building scankeys #8992
+142
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would lead to assertion failure in debug builds and ignore additional filter in non-debug builds. This would not lead to data corruption but it could lead to more data being decompressed than necessary for DML operations on compressed chunks. Found by sqlsmith (cherry picked from commit 91ce04d)
timescale-automation
added
the
is-auto-backport
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.24.x #8992 +/- ##
==========================================
+ Coverage 82.52% 82.61% +0.08%
==========================================
Files 249 249
Lines 48547 48520 -27
Branches 12395 12391 -4
==========================================
+ Hits 40062 40083 +21
- Misses 3520 3530 +10
+ Partials 4965 4907 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #8988: Don't ignore additional filters on same column when building scankeys.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Don't ignore additional filters on same column when building scankeys
This would lead to assertion failure in debug builds and ignore
additional filter in non-debug builds. This would not lead to data
corruption but it could lead to more data being decompressed than
necessary for DML operations on compressed chunks.
Found by sqlsmith