attempt to fix #744 #761
Merged
attempt to fix #744 #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system #744 only reporoducible with a mingw build, with VC build I can no longer reproduce it, so if fixing mingw build does not work, this is the next thing I can try, if this one for some reason does not pan out.
This PR updates SDL versions to the latest ones for SDL, and with the latest version, the issue seems to be no longer there. I did zero testing if the game works well with the upgraded SDL, so someone will need to take a look. This change only affect the windows build, macos and linux builds are unaffected.
The artifact can be found here:
https://github.com/AndrewSav/BrogueCE/actions/runs/19418464531