Extract shared PSE reading logic to reduce duplication #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add readPseApplications() helper function that encapsulates PSE selection and record reading - Add PseAppInfo, PseRecordData, and PseReadResult interfaces - Refactor listApps() to use the shared helper - Refactor cardInfo() to use the shared helper - Refactor dumpCard() to use the shared helper - Add tests for readPseApplications() This reduces code duplication across three functions that all performed the same PSE reading pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
readPseApplications()helper function that encapsulates PSE selection and record readingPseAppInfo,PseRecordData, andPseReadResultinterfaceslistApps()to use the shared helpercardInfo()to use the shared helperdumpCard()to use the shared helperreadPseApplications()This reduces code duplication across three functions that all performed the same PSE reading pattern.
Test plan
Closes #73