Skip to content

Conversation

@crazy-max
Copy link
Collaborator

@crazy-max crazy-max commented Jan 26, 2025

relates to #215 (comment)

@crazy-max crazy-max requested a review from tonistiigi January 26, 2025 16:14
@crazy-max crazy-max marked this pull request as ready for review January 26, 2025 16:14
Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my tests it took much longer to hit this than 2 minutes

@crazy-max crazy-max force-pushed the test-npm-version branch 3 times, most recently from 2870aed to e6f1215 Compare January 28, 2025 10:59
@crazy-max
Copy link
Collaborator Author

In my tests it took much longer to hit this than 2 minutes

Increased to 10m

@crazy-max
Copy link
Collaborator Author

Got a repro on ubuntu 24.04 but not 22.04 without --disable-pie: https://github.com/tonistiigi/binfmt/actions/runs/13008951929/job/36282137456?pr=221#step:6:316

#6 375.8 10.9.2
#6 377.5 10.9.2
#6 379.1 10.9.2
#6 380.8 10.9.2
#6 382.5 10.9.2
#6 384.1 10.9.2
#6 385.8 10.9.2
#6 387.5 10.9.2
#6 389.2 10.9.2
#6 390.9 10.9.2
#6 392.6 10.9.2
#6 394.4 10.9.2
#6 394.5 Segmentation fault (core dumped)

cc @ajbarber

@crazy-max crazy-max force-pushed the test-npm-version branch 2 times, most recently from 2e9a142 to 2d57ab7 Compare January 29, 2025 19:02
@ajbarber
Copy link
Contributor

ajbarber commented Jan 29, 2025

Got a repro on ubuntu 24.04 but not 22.04 without --disable-pie: https://github.com/tonistiigi/binfmt/actions/runs/13008951929/job/36282137456?pr=221#step:6:316

#6 375.8 10.9.2
#6 377.5 10.9.2
#6 379.1 10.9.2
#6 380.8 10.9.2
#6 382.5 10.9.2
#6 384.1 10.9.2
#6 385.8 10.9.2
#6 387.5 10.9.2
#6 389.2 10.9.2
#6 390.9 10.9.2
#6 392.6 10.9.2
#6 394.4 10.9.2
#6 394.5 Segmentation fault (core dumped)

cc @ajbarber

I think this is either:

  • An additional bug, to the one resolved by removing --disable-pie, specific to Ubuntu 24.04, for example some glibc change.
  • Random failures, which may be captured on other ubuntu versions with further runs of this test set, and hence the PR removing --disable-pie has done nothing.

@crazy-max crazy-max marked this pull request as draft January 29, 2025 20:17
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
@crazy-max
Copy link
Collaborator Author

Looks good on ubuntu 24.04 now.

@crazy-max crazy-max marked this pull request as ready for review October 22, 2025 12:05
@crazy-max crazy-max requested a review from tonistiigi October 22, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants