Tie-breaker fix for CORE-2303 #7145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| function assignRanks(members, scoreKey, rankKey) { | ||
| function assignRanks(members, scoreKey, rankKey, options = {}) { | ||
| const { tieBreaker } = options; |
There was a problem hiding this comment.
[correctness]
The assignRanks function now includes a tieBreaker option, which is a good addition for handling tie-breaking logic. However, ensure that the tieBreaker function provided is well-tested, especially for edge cases where the tie-breaking value might be null or undefined. This will help avoid unexpected behavior during sorting.
| "bestProvisionalScore", | ||
| "provisionalRank", | ||
| { | ||
| tieBreaker: (entry) => { |
There was a problem hiding this comment.
[design]
The tieBreaker function in assignRanks is using Number.POSITIVE_INFINITY as a default for null or undefined values. While this is a valid approach, ensure that this logic aligns with the intended ranking system. If the tie-breaking value is crucial, consider documenting or validating the input to prevent misuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.