Hotfix - Email fix for PS-455 #21
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| expect(memberUpdateMock).toHaveBeenCalledWith({ | ||
| where: { userId }, | ||
| expect(memberUpdateManyMock).toHaveBeenCalledWith({ | ||
| where: { userId: BigInt(userId) }, |
There was a problem hiding this comment.
[correctness]
The use of BigInt for userId in the where clause is inconsistent with other parts of the code where userId is used as a number. Ensure that the data type is consistent across the application to avoid potential type-related issues.
| expect(memberUpdateMock).toHaveBeenCalledWith({ | ||
| where: { userId }, | ||
| expect(memberUpdateManyMock).toHaveBeenCalledWith({ | ||
| where: { userId: BigInt(userId) }, |
There was a problem hiding this comment.
[correctness]
The use of BigInt for userId in the where clause is inconsistent with other parts of the code where userId is used as a number. Ensure that the data type is consistent across the application to avoid potential type-related issues.
| } | ||
|
|
||
| if (emailChanged) { | ||
| const memberUserId = BigInt(userId); |
There was a problem hiding this comment.
[correctness]
The conversion of userId to BigInt is necessary for the where clause in the memberPrisma.member.update method. Ensure that userId is always a valid number that can be safely converted to BigInt to avoid runtime errors.
| await this.memberPrisma.member.update({ | ||
| where: { userId }, | ||
| const updateResult = await this.memberPrisma.member.update({ | ||
| where: { userId: memberUserId }, |
There was a problem hiding this comment.
[💡 maintainability]
Consider adding error handling for the updateResult to ensure that the update operation was successful. This can help in diagnosing issues if the update fails silently.
No description provided.