PM-589 Fix Load more logic #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const opportunities = data ? data.flat() : [] | ||
|
|
||
| return { data: opportunities, isValidating, setSize: (s: number) => { setSize(s) }, size } | ||
| const lastPage = data[data.length - 1] || [] |
There was a problem hiding this comment.
Check if data is not null or undefined before accessing data.length to prevent potential runtime errors.
| columns={tableColumns} | ||
| data={tableData} | ||
| moreToLoad={isValidating || opportunities.length > 0} | ||
| moreToLoad={hasMoreOpportunities} |
There was a problem hiding this comment.
The variable hasMoreOpportunities should be defined and initialized properly in the component to ensure it accurately reflects whether there are more opportunities to load. Verify that hasMoreOpportunities is correctly set and updated based on the data source.
kkartunov
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-589
What's in this PR?
Add logic to Show load more button only when there is more data to load