Allow jumping to jump_addr if it was requested in the script#1
Open
ynezz wants to merge 3 commits intotoradex:imx_usb_batch_mode_refactoredfrom
Open
Conversation
Signed-off-by: Petr Štetiar <ynezz@true.cz>
Currently the jump_command.addr is hardcoded to header_addr, so it will always jump to header_addr, even if we specify different jump address in the script. So this patch allows jumping to jump_addr if it was specified. Signed-off-by: Petr Štetiar <ynezz@true.cz>
This change would allow us to load just part of the image. u-boot-with-spl.bin:load 0x00907400,load_size 0x11000,jump 0x00907400 One can specify load_size in dec or hex notation. Signed-off-by: Petr Štetiar <ynezz@true.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm preparing support for Apalis/Ixora for OpenWrt, and in my recovery script I'm flashing SPL, U-boot and rootfs in one go:
For that I'm using following imx_loader script/config:
Currently it's not possible to load image and jump to the script loaded in different address:
It would simply load rootfs to
0x12500000but also jump to0x12500000and not to the script at0x12000000. This PR contains fix for this issue, then there's one cosmetic fixup andload_sizecommand addition, which was helpful for me during development.Once I'm finished with the support in OpenWrt, I would like to write recovery/flashing procedure and I would like to point to this upstream imx_loader repository and branch on GitHub as I don't want to maintain fork. Could you please consider merging those small changes? Thanks!