Add support for custom learning strategy #3921
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3921 +/- ##
==========================================
- Coverage 64.81% 64.80% -0.01%
==========================================
Files 1178 1178
Lines 139912 139907 -5
==========================================
- Hits 90678 90664 -14
- Misses 49234 49243 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nathanielsimard
approved these changes
Oct 28, 2025
| /// Struct to minimise parameters passed to [LearningMethod::learn] | ||
| /// These components are used during training | ||
| pub(crate) struct LearnerComponents<LC: LearnerComponentTypes> { | ||
| pub struct LearnerComponents<LC: LearnerComponentTypes> { |
There was a problem hiding this comment.
Some of the docs is wrong here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
Can now create custom learning strategies.
Added an example of a custom learning strategy.
We now need to pass learning_strategy to the build method of the Learner.
Testing
Created an example to test it. Could not test the Multi-device case yet.