Skip to content

Conversation

@tob-joe
Copy link

@tob-joe tob-joe commented Nov 25, 2025

Summary

  • Converted get_mark(&self) method to MARK associated constant in the Inscribe trait
  • Updated derive macro to generate constants instead of methods
  • Modified documentation to reflect the new API
  • Adapted tests to use constant references for custom marks

Test plan

  • ✅ All existing tests pass
  • ✅ Test with custom mark updated to use constant reference

Resolves #6

🤖 Generated with Claude Code

Changes:
- Updated trait definition to use const MARK
- Modified derive macro to generate constants instead of methods
- Updated documentation to reflect the new API
- Adapted test to use constant reference for custom marks

Resolves trailofbits#6

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@opal-escent
Copy link
Collaborator

In the updated docs, the MARK constant is still referred to as a method (see lines 8 and 9 of inscribe.rs). Can you update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_mark could be an associated constant

2 participants