Skip to content

The image file name is no longer transformed to lower case #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

The image file name is no longer transformed to lower case #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1c469b
The image title is no longer transformed to lower case
arnee May 12, 2017
ced02b6
Fix Image::parseImage
teohhanhui May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,32 +58,30 @@ Image.validInputFormats = ['jpeg', 'jpg', 'png', 'webp', 'tiff', 'tif', 'gif'];
Image.validOutputFormats = ['jpeg', 'png', 'webp'];

// Determine the name and format of the requested image
Image.prototype.parseImage = function(request){
var fileStr = _.last(request.path.split('/'));
var exts = fileStr.split('.').map( function (item) {
return item.toLowerCase();
});
Image.prototype.parseImage = function (request) {
var filenameParts = _.last(request.path.split('/')).split('.');
var inputFormat;
var outputFormat;

// clean out any metadata format
if (exts[exts.length - 1] === 'json') {
this.format = exts[exts.length - 2];
exts.pop();
fileStr = exts.join('.');
if (_.last(filenameParts).toLowerCase() === 'json') {
filenameParts.pop();
this.format = _.last(filenameParts).toLowerCase();
}

// if path contains valid output format, remove it from path
if (exts.length >= 3) {
var inputFormat = exts[exts.length - 2];
var outputFormat = exts.pop();
if (filenameParts.length >= 3) {
inputFormat = filenameParts[filenameParts.length - 2].toLowerCase();
outputFormat = filenameParts[filenameParts.length - 1].toLowerCase();

if (_.indexOf(Image.validInputFormats, inputFormat) > -1 &&
_.indexOf(Image.validOutputFormats, outputFormat) > -1) {
this.outputFormat = outputFormat;
fileStr = exts.join('.');
filenameParts.pop();
}
}

this.image = fileStr;
this.image = filenameParts.join('.');
};


Expand Down