[triton_kernels] Force matmul_ogs output to be TMA-compatible #8774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TMA requires innermost dimension to be contiguous and other dimensions to have strides that are multiples of 16 bytes. Previously, it wasn't enforced, and if output happened to have odd dimensions, trigerred an assertion when creating TMA descriptor later on. This change modifies apply_allocation to: - Pad the innermost dimension before allocation and then slice it if the output tensor was not provided - Verify the strides of the output tensor if it was provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TMA requires innermost dimension to be contiguous and other dimensions to have strides that are multiples of 16 bytes. Previously, it wasn't enforced, and if output happened to have odd dimensions, trigerred an assertion when creating TMA descriptor later on. This change modifies apply_allocation to:
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)